Genshi doesn't add newline char after "</html>"

[yaohua2000@…]

My template ends with "</html>" and a newline char, but after "genshied", it removed my newline char at the end of file. A text file should be ended with a newline char. Please add it back.

[anonymous]

While your template file might be a text file, (X)HTML output is not. And in XML, there is nothing outside the root element, so having no newline makes sense to me.

[cmlenz]

I agree that Genshi shouldn't be stripping whitespace after the last close tag. Will look into this for 0.4.1.

[anonymous]

Well, generally spoken, whitespace after close tags *is* important to create far more readable output. So I agree in that Genshi shouldn't strip it.

[cmlenz]

Okay, the problem is that whitespace after the document element is “ignorable whitespace”, and thus not passed to Genshi as normal character data. The only way to learn about such whitespace is using the DefaultHandler (implemented by XMLParser._handle_other in Genshi), but then we also get a whole lot of other ignorable whitespace, which, well, ought to be ignored.

So right now I'm not sure what the right solution would be.

[cmlenz]

For the reasons explained in my previous comment, I consider fixing this issue to high risk for the maintenance branch. I'll look into a proper solution for 0.5.

[cmlenz]

Postponing again, sorry. If anyone can come up with a patch for this, I'd be grateful.

[Carsten Klein <carsten.klein@…>]

Replying to cmlenz:

Postponing again, sorry. If anyone can come up with a patch for this, I'd be grateful.

Why not make this a feature of the serializers found in the output module?

However, it should be made configurable whether the serializer should add a new line character at the end of the output.

See the attached propopsal for an untested patch.

[Carsten Klein <carsten.klein@…>]

Initial patch for this feature