SystemError: error return without exception set

[rblank]

When _speedups is enabled:

>>> from genshi.core import Markup
>>> Markup(',').join(iter('abc'))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
SystemError: error return without exception set

Markup.join() is documented as taking a sequence, so this is an invalid call. But it should raise a TypeError instead. Interestingly, this makes the method slightly incompatible with the pure-Python one, which accepts iterators.

The fix is something like:

genshi/_speedups.c

@@ -251 +251 @@
         return NULL;
     }
     if (!PySequence_Check(seq)) {
+        PyErr_SetString(PyExc_TypeError, "join() requires a sequence");
         return NULL;
     }
     n = PySequence_Size(seq);

[rblank]

Accept iterators for Markup.join().

[rblank]

Alternatively, Markup.join() could be made to accept iterators, in the same way as its pure Python implementation does. 574-markup-join-iter.patch​ implements this.

[hodgestar]

Thanks for the patch rblank!

Test and patch committed in r1266. Backported to 0.7.x (r1267) and 0.6.x (r1268).