genshi broken with python 3.5

[anonymous]

Genshi 0.7 is incompatible with Python 3.5 due to changes in Python's ast module API. Of course ast's API is not guaranteed to be stable across Python releases.

Here's a link to build failures in an Ubuntu archive test rebuild against Python 3.5. Scroll to the bottom to see the failures. I don't have a fix yet.

​https://launchpadlibrarian.net/210474355/buildlog_ubuntu-wily-amd64.genshi_0.7-3_BUILDING.txt.gz

[trac@…]

Patch which passes tests in python 3.5

[trac@…]

(Tim Hatch here, can't recall my edgewall login at the moment.)

I attached a patch which passes the tests. If anyone has a fuzzer to throw at it, I would appreciate additional confirmation that it works. The AST code is a little tricky.

[barry@…]

I had to make one change to t602.diff. Since in Ubuntu we build versions for Python 2.7, 3.4, and 3.5 (currently), you first have to check if _ast.Starred exists, which it doesn't for Python 2.7. Thus:

                if hasattr(_ast, 'Starred') and isinstance(arg, _ast.Starred):
                    # Python 3.5+
                    self.star_args = arg.value.id
                else:
                    # only names
                    self.args.append(arg.id)

What's the status of getting a new version of Genshi released with this fix?

[jaraco@…]

I'm pretty sure this is a duplicate of #582 (already fixed, just not released).

[hodgestar]

Agreed. Closing.

[anonymous]

The issue is not solved with #582, the diff still applies cleanly and seems to fix the reported issue

[lele]

FYI, my ​Python 3 only branch fixes this and other minor issues.

[toni.sissala@…]

Yup. Still broken. At least with Python 3.5 and Genshi 0.7 (latest from pip) I cannot use

py:attrs={'attr':None}

It gives me

lib/python3.5/site-packages/genshi/template/astutil.py", line 90, in visit
    raise Exception('Unhandled node type %r' % type(node))
Exception: Unhandled node type <class '_ast.NameConstant'>